Allow using a separate key file when setting up 'Sign in with Apple' #4393
Conversation
|
|
No worries. I believe I have implemented your change requests now and I appreciate the quick review. Let me know if you don't agree with some changes I did edit: I have built the new resulting MAS cli using this branch and have deployed it fine in my cluster, and verified Apple SSO works. |
…ate_key in db using the provided file (if given)
Feat/populate priv key sync
|
@sandhose I have now implemented the private key reading in the |
| } else if let Some(mut siwa) = provider.sign_in_with_apple.clone() { | ||
| // if private key file is defined and not private key (raw), we populate the | ||
| // private key to hold the content of the private key file. | ||
| // private key (raw) takes precedence so both can be defined | ||
| // without issues | ||
| if siwa.private_key.is_none() { | ||
| if let Some(private_key_file) = siwa.private_key_file.take() { | ||
| let key = tokio::fs::read_to_string(private_key_file).await?; | ||
| siwa.private_key = Some(key); | ||
| } | ||
| } | ||
| let encoded = serde_json::to_vec(&siwa)?; |
There was a problem hiding this comment.
This does mean that it's possible to end up in the database with no private key if none are set. But I'm fine with that, SiWA is sufficiently niche anyway :)
sandhose
changed the title
sandhose
added
A-Configuration
3 participants
This change requires using a private key file for Apple Sign-In authentication instead of directly pasting the key content.
Fixes #4391